Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL Lab] Improve perf for filterable table rendering #8011

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Aug 8, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Uses @kristw's new getMultipleTextDimensions to improve perf about 3x for FilterableTable rendering

TEST PLAN

Ensure tables in sql lab still render properly

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@kristw @graceguo-supercat @betodealmeida

@kristw
Copy link
Contributor

kristw commented Aug 8, 2019

Hmm. Code looks good. I was not aware that array.flat() has been implemented.
Not sure why CI fails. Does this work locally for you?

@etr2460 etr2460 force-pushed the erik-ritter--get-multiple-text-dims branch from f07d52e to eef9909 Compare August 8, 2019 19:50
@etr2460
Copy link
Member Author

etr2460 commented Aug 8, 2019

array.flat() is now implemented in modern browsers, but cypress uses an older version of headless chrome (according to @graceguo-supercat). I've reverted to the old school [].concat(...array) syntax.

@graceguo-supercat
Copy link

graceguo-supercat commented Aug 8, 2019

see discussion in cypress community: https://gitter.im/cypress-io/cypress/archives/2019/01/24,
[].flat() is not supported in electron 59.

@etr2460 etr2460 force-pushed the erik-ritter--get-multiple-text-dims branch from eef9909 to a1bc4bf Compare August 9, 2019 21:04
@etr2460
Copy link
Member Author

etr2460 commented Aug 9, 2019

cc @robdiciuccio if you're interested in some of the client side sql lab perf fixes

@etr2460 etr2460 closed this Aug 9, 2019
@etr2460 etr2460 reopened this Aug 9, 2019
@codecov-io
Copy link

Codecov Report

Merging #8011 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8011      +/-   ##
==========================================
+ Coverage   65.58%   65.58%   +<.01%     
==========================================
  Files         469      469              
  Lines       22461    22462       +1     
  Branches     2438     2437       -1     
==========================================
+ Hits        14730    14731       +1     
  Misses       7611     7611              
  Partials      120      120
Impacted Files Coverage Δ
...src/components/FilterableTable/FilterableTable.jsx 78.73% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6df2a71...a1bc4bf. Read the comment docs.

@kristw kristw merged commit f039e17 into apache:master Aug 12, 2019
@kristw kristw mentioned this pull request Aug 13, 2019
12 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.35.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants