-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQL Lab] Improve perf for filterable table rendering #8011
[SQL Lab] Improve perf for filterable table rendering #8011
Conversation
Hmm. Code looks good. I was not aware that |
f07d52e
to
eef9909
Compare
|
see discussion in cypress community: https://gitter.im/cypress-io/cypress/archives/2019/01/24, |
eef9909
to
a1bc4bf
Compare
cc @robdiciuccio if you're interested in some of the client side sql lab perf fixes |
Codecov Report
@@ Coverage Diff @@
## master #8011 +/- ##
==========================================
+ Coverage 65.58% 65.58% +<.01%
==========================================
Files 469 469
Lines 22461 22462 +1
Branches 2438 2437 -1
==========================================
+ Hits 14730 14731 +1
Misses 7611 7611
Partials 120 120
Continue to review full report at Codecov.
|
CATEGORY
Choose one
SUMMARY
Uses @kristw's new
getMultipleTextDimensions
to improve perf about 3x for FilterableTable renderingTEST PLAN
Ensure tables in sql lab still render properly
ADDITIONAL INFORMATION
REVIEWERS
@kristw @graceguo-supercat @betodealmeida