[bugfix] Fix deck_polygon metric bug and update examples chart #8025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8025 +/- ##
=======================================
Coverage 65.54% 65.54%
=======================================
Files 469 469
Lines 22474 22474
Branches 2441 2441
=======================================
Hits 14730 14730
Misses 7624 7624
Partials 120 120
Continue to review full report at Codecov.
|
thunter009
approved these changes
Aug 15, 2019
|
@betodealmeida is this good to go? Would love to kill this bug. |
|
Nice, thanks for fixing this, @villebro! |
mistercrunch
added
🍒 0.34.1
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…e#8025) * Fix deck_polygon bug and update examples chart * Change js elevation to native ad-hoc metric * Move scale from metric to native multiplier * Remove redundant js_columns and change color scheme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Previously
deck_polygonelevation only worked with old school metrics or fixed values. PR #7924 added support for ad-hoc metrics, but broke support for old-school metrics. This PR makes all elevation types work (ad-hoc metric, oldschool metric and fixed), and adds a few bells and whistles to the example chart, namely coloring based on total population + legend formatting as introduced in #7951 . Also, JS data mutator logic is moved to native elements.BEFORE
AFTER
TEST PLAN
REVIEWERS
@thunter009 @mistercrunch