[SIP-36] Update CONTRIBUTING with TypeScript details #9185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
commented
Feb 21, 2020
| - [Testing](#testing) | ||
| - [JavaScript testing](#javascript-testing) | ||
| - [Integration testing](#integration-testing) | ||
| - [Contributing](#contributing) |
There was a problem hiding this comment.
This is an autogenerated table of contents from the headers in this file
Codecov Report
@@ Coverage Diff @@
## master #9185 +/- ##
=======================================
Coverage 59.13% 59.13%
=======================================
Files 372 372
Lines 11938 11938
Branches 2925 2925
=======================================
Hits 7059 7059
Misses 4699 4699
Partials 180 180Continue to review full report at Codecov.
|
nytai
approved these changes
Feb 24, 2020
willbarrett
approved these changes
Feb 24, 2020
kristw
approved these changes
Feb 24, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Updates CONTRIBUTING.md with the details agreed upon in SIP-36
TEST PLAN
CI
ADDITIONAL INFORMATION
REVIEWERS
to: @nytai @graceguo-supercat @kristw @rusackas