Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding config element for alert message in navbar #938

Merged
merged 1 commit into from
Aug 13, 2016
Merged

Adding config element for alert message in navbar #938

merged 1 commit into from
Aug 13, 2016

Conversation

mistercrunch
Copy link
Member

@ascott @bkyryliuk

Adding this to make it clear that our staging is not production
screen shot 2016-08-12 at 11 46 29 am

@coveralls
Copy link

coveralls commented Aug 12, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 81.237% when pulling 9150919 on mistercrunch:warning_msg into e243a14 on airbnb:master.

bkyryliuk
bkyryliuk reviewed Aug 12, 2016
View reviewed changes
caravel/config.py
# If defined, shows this text in an alert-warning box in the navbar
# one example use case may be "STAGING" to make it clear that this is
# not the production version of the site.
WARNING_MSG = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ WARNING_MSG / NAV_BAR_WARNING_MSG

@bkyryliuk
Copy link
Member

LGTM
just a minor comment about the config var name.

@mistercrunch
Copy link
Member Author

I think I'll stick with WARNING_MSG as I'd have to change on the chef (in like 5-10 places total) side as well and the boxes are going through their first converge now.

@mistercrunch mistercrunch merged commit 1b9458d into apache:master Aug 13, 2016
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
@matrix-compute matrix-compute mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mistercrunch @coveralls @bkyryliuk