Migrating unique BigNumber(/Total) controls #9389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
commented
Mar 26, 2020
rusackas
force-pushed
the
Migrating-unique-BigNumber-controls
branch
from
eac333a
to
31baf94
Compare
kristw
approved these changes
Mar 26, 2020
rusackas
force-pushed
the
Migrating-unique-BigNumber-controls
branch
2 times, most recently
from
43f623b
to
cfb4bbb
Compare
kristw
approved these changes
Mar 27, 2020
|
I also made change to the Big Number controls here: #9341 It seems there will be conflicts. Which one should we merge first? |
|
I'll merge the other one first then since this one's ci is still broken. |
|
Not really sure why CI is failing on this one (was actually just starting to look into it and try reproducing locally)... I just restarted Travis to see if I get lucky ;) Happy to rebase (or even re-do) these changes on an updated |
rusackas
force-pushed
the
Migrating-unique-BigNumber-controls
branch
from
49b1754
to
d5e9bcf
Compare
|
Closing in favor of #9440 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Moving unique control(s) from
controls.jsxto/explore/controlPanels/BigNumber.jsand/explore/controlPanels/BigNumberTotal.jsBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@kristw