Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboards] Fix, API update slug uniqueness refusing empty string #9417

Merged
merged 2 commits into from
Mar 30, 2020
Merged

[dashboards] Fix, API update slug uniqueness refusing empty string #9417

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17882d3
[dashboards] Fix, API update slug uniqueness refusing empty string
dpgaspar Mar 30, 2020
ff41547
[dashboards] tests
dpgaspar Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions superset/dashboards/dao.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,12 @@ def validate_slug_uniqueness(slug: str) -> bool:

@staticmethod
def validate_update_slug_uniqueness(dashboard_id: int, slug: str) -> bool:
dashboard_query = db.session.query(Dashboard).filter(
Dashboard.slug == slug, Dashboard.id != dashboard_id
)
return not db.session.query(dashboard_query.exists()).scalar()
if slug:
dashboard_query = db.session.query(Dashboard).filter(
Dashboard.slug == slug, Dashboard.id != dashboard_id
)
return not db.session.query(dashboard_query.exists()).scalar()
return True

@staticmethod
def bulk_delete(models: List[Dashboard], commit=True):
Expand Down