feat: Add controlGroups to formData #9740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
commented
May 5, 2020
| @@ -107,6 +109,7 @@ describe('controlUtils', () => { | |||
| name: 'all_columns', | |||
| config: { | |||
| type: 'SelectControl', | |||
| controlGroup: 'columns', | |||
There was a problem hiding this comment.
Naming suggestions are welcomed. I went between requestGroup and controlGroup, bud decided in favor of controlGroup, as I expect it will be more intuitive for viz developers.
rusackas
approved these changes
May 5, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This adds a field
controlGroupstoformDatato facilitate automatic control grouping for chart data requests.TEST PLAN
CI
ADDITIONAL INFORMATION
REVIEWERS
@kristw @rusackas @suddjian