Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move bullet string manipulation to frontend #9773

Merged
merged 1 commit into from
May 11, 2020

Conversation

villebro
Copy link
Member

@villebro villebro commented May 8, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Bump NVD3 viz plugin to latest version and defer Bullet Viz string manipulation to frontend ( apache-superset/superset-ui#440 ).

AFTER SCREENSHOT (no change)

image

TEST PLAN

Local testing + CI

ADDITIONAL INFORMATION

REVIEWERS

@codecov-io
Copy link

codecov-io commented May 8, 2020

Codecov Report

Merging #9773 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9773      +/-   ##
==========================================
+ Coverage   70.81%   70.85%   +0.04%     
==========================================
  Files         586      586              
  Lines       30442    30420      -22     
  Branches     3120     3120              
==========================================
- Hits        21558    21555       -3     
+ Misses       8770     8751      -19     
  Partials      114      114              
Flag Coverage Δ
#cypress 53.66% <ø> (-0.08%) ⬇️
#javascript 59.07% <ø> (ø)
#python 71.02% <ø> (+0.08%) ⬆️
Impacted Files Coverage Δ
superset/viz.py 71.97% <ø> (+0.47%) ⬆️
superset/viz_sip38.py 0.00% <ø> (ø)
...rontend/src/SqlLab/components/QueryAutoRefresh.jsx 65.90% <0.00%> (-6.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a21391...7314340. Read the comment docs.

@villebro villebro requested a review from rusackas May 8, 2020 07:09
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit f369ab3 into apache:master May 11, 2020
@rusackas rusackas deleted the villebro/trim-bullet branch May 11, 2020 18:49
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants