Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QueryContext deserialization test #9778

Merged
merged 2 commits into from
May 11, 2020

Conversation

villebro
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Fix a few bugs discovered during testing and add unit test that would have caught the deserialization error.

TEST PLAN

Local testing + CI

ADDITIONAL INFORMATION

@codecov-io
Copy link

codecov-io commented May 11, 2020

Codecov Report

Merging #9778 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9778   +/-   ##
=======================================
  Coverage   70.77%   70.77%           
=======================================
  Files         587      587           
  Lines       30460    30460           
  Branches     3121     3121           
=======================================
  Hits        21558    21558           
  Misses       8788     8788           
  Partials      114      114           
Flag Coverage Δ
#cypress 53.66% <ø> (ø)
#javascript 59.00% <ø> (ø)
#python 70.93% <100.00%> (ø)
Impacted Files Coverage Δ
superset/charts/schemas.py 100.00% <100.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 66.81% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24db9ab...857ada8. Read the comment docs.

@villebro villebro requested a review from dpgaspar May 11, 2020 08:02
@villebro villebro merged commit 42b10ae into apache:master May 11, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants