Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilterBox,BigNumber,WorldMap: Handle empty results - second attempt #9789

Merged
merged 3 commits into from
May 17, 2020
Merged

FilterBox,BigNumber,WorldMap: Handle empty results - second attempt #9789

merged 3 commits into from
May 17, 2020

Conversation

elukey
Copy link
Contributor

@elukey elukey commented May 12, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

This pull request is a follow up of #9671, reverted in #9755 due to a regression introduced to the FilterBox. I broke down the commit into three, and improved the code for the FilterBox.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

See screenshots in #9671.

TEST PLAN

Trying various combination of FilterBox, WorldMap and BigNumber charts with empty results.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@elukey
FilteBox: handle empty results (second attempt)
6735be9 
This change was originally attempted in apache#9671 but reverted
since it broke FilterBox charts with only a time selector.

After some tests I reworked the patch to avoid returning None,
but instead returning an empty list for each col/selector with
an empty dataframe associated. This allows to see all the selectors
without any breakage.
@elukey
BigNumberViz: avoid user facing errors when the dataframe is empty
1c7739c
@elukey
WorldMapViz: avoid user facing errors when the dataframe is empty
902a3a1
@codecov-io
Copy link

codecov-io commented May 12, 2020 •
edited
Loading

Codecov Report

Merging #9789 into master will decrease coverage by 17.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #9789       +/-   ##
===========================================
- Coverage   70.82%   53.72%   -17.11%     
===========================================
  Files         587      352      -235     
  Lines       30435    11243    -19192     
  Branches     3121     2785      -336     
===========================================
- Hits        21555     6040    -15515     
+ Misses       8766     5023     -3743     
- Partials      114      180       +66
Flag Coverage Δ
#cypress 53.72% <ø> (+0.06%) ⬆️
#javascript ?
#python ?
Impacted Files Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.19%) ⬇️
.../src/dashboard/components/FilterIndicatorGroup.jsx 11.76% <0.00%> (-88.24%) ⬇️
...c/explore/components/controls/withVerification.jsx 9.09% <0.00%> (-87.88%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...c/dashboard/components/gridComponents/Markdown.jsx 6.59% <0.00%> (-82.42%) ⬇️
...uperset-frontend/src/utils/getClientErrorObject.ts 0.00% <0.00%> (-82.15%) ⬇️
superset-frontend/src/components/Link.tsx 7.69% <0.00%> (-79.81%) ⬇️
... and 367 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e3a4a...902a3a1. Read the comment docs.

@elukey
Copy link
Contributor Author

elukey commented May 12, 2020

The test that fails is test_copy_dash but I am not super sure if my pull request is related to it..

Adding @villebro @graceguo-supercat @etr2460 since this is a follow up on a reverted change. Let me know your thoughts, thanks for the patience!

etr2460
etr2460 approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm now, although you might need to update viz_sip38.py too? @villebro can you comment on that and what the relationship is between viz.py and viz_sip38.py?

@elukey
Copy link
Contributor Author

elukey commented May 16, 2020

Ah interesting, I wasn't aware of #9187

@villebro do I need to update my pull request?

@villebro
Copy link
Member

Just a flaky test; restarted CI, should be ok:
image
(I've been waiting for that annoying flaky test to fail again, will try to fix it so we don't hit this again).

No need to update viz_sip38.py, I will do an update pass later pulling in changes in one go to keep the workflow simple for regular PRs.

@etr2460
Copy link
Member

etr2460 commented May 17, 2020

sounds good, thanks for checking Ville! I'll merge this now

@etr2460 etr2460 merged commit 5ab5457 into apache:master May 17, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etr2460 etr2460 etr2460 approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.37.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elukey @codecov-io @villebro @etr2460 @mistercrunch