Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-4064 Update node library dependencies #1175

Closed
wants to merge 7 commits into from
Closed

THRIFT-4064 Update node library dependencies #1175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e8c2015
Update node library dependencies
zertosh Feb 1, 2017
cf93b73
Use Node 4.x in Ubuntu Docker image
zertosh Feb 8, 2017
15db23d
Add bufferutil and utf-8-validate to devDeps
zertosh Feb 9, 2017
a92f265
Use Node 4.x in Debian Docker image
zertosh Feb 10, 2017
f7a0d8d
Use ws@^1.0.0 and Node 0.12.x
zertosh Feb 15, 2017
2e77327
Use correct ws compatible bufferutil & utf-8-validate
zertosh Feb 24, 2017
c1f1d33
Use node 4.x but keep ws@^1.0.0
zertosh Feb 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions build/docker/debian/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,11 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
neko-dev \
libneko0

RUN apt-get update && apt-get install -y --no-install-recommends \
# Node.js dependencies - THRIFT-4064 says it must be >= 4.x
RUN curl -sL https://deb.nodesource.com/setup_4.x | bash -
RUN apt-get install -y --no-install-recommends \
`# Node.js dependencies` \
nodejs \
nodejs-dev \
nodejs-legacy \
npm
nodejs

RUN apt-get update && apt-get install -y --no-install-recommends \
`# CSharp dependencies` \
Expand Down
11 changes: 4 additions & 7 deletions build/docker/ubuntu/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,11 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
neko-dev \
libneko0

RUN apt-get update && apt-get install -y --no-install-recommends \
# Node.js dependencies - THRIFT-4064 says it must be >= 4.x
RUN curl -sL https://deb.nodesource.com/setup_4.x | bash -
RUN apt-get install -y --no-install-recommends \
`# Node.js dependencies` \
nodejs \
nodejs-dev \
nodejs-legacy
nodejs

RUN apt-get update && apt-get install -y --no-install-recommends \
`# CSharp dependencies` \
Expand Down Expand Up @@ -183,9 +183,6 @@ RUN mkdir -p /usr/lib/haxe && \
haxelib setup /usr/lib/haxe/lib && \
haxelib install hxcpp

# Node.js
RUN curl -sSL https://www.npmjs.com/install.sh | sh

# D
RUN curl -sSL http://downloads.dlang.org/releases/2.x/2.070.0/dmd_2.070.0-0_amd64.deb -o /tmp/dmd_2.070.0-0_amd64.deb && \
dpkg -i /tmp/dmd_2.070.0-0_amd64.deb && \
Expand Down
12 changes: 7 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,20 +32,22 @@
},
"main": "./lib/nodejs/lib/thrift",
"engines": {
"node": ">= 0.2.4"
"node": ">= 0.12.0"
},
"dependencies": {
"node-int64": "~0.3.0",
"q": "1.0.x",
"ws": "~0.4.32"
"node-int64": "^0.4.0",
"q": "^1.0.0",
"ws": "^1.0.0"
Copy link

@ledara1 ledara1 Sep 12, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be >=1.1.1. In this version most of security issues were fixed. Please update the version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ledara1 I'm pretty sure this work was abandoned. We've since moved most of the build targets to more recent distributions, but this file wasn't updated. There is a new ubuntu-xenial docker image which, if you would be able to update the package.json file to match, would be useful.

},
"devDependencies": {
"buffer-equals": "^1.0.3",
"bufferutil": "~2.0.0",
"commander": "2.1.x",
"connect": "2.7.x",
"istanbul": "^0.3.5",
"run-browser": "^2.0.1",
"tape": "~3.5.0"
"tape": "~3.5.0",
"utf-8-validate": "~3.0.0"
},
"scripts": {
"cover": "lib/nodejs/test/testAll.sh COVER",
Expand Down