Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tika 4137 #1353

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Tika 4137 #1353

merged 4 commits into from
Sep 22, 2023

Conversation

theit
Copy link
Contributor

@theit theit commented Sep 22, 2023

Thanks for your contribution to Apache Tika! Your help is appreciated!

Before opening the pull request, please verify that

  • there is an open issue on the Tika issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
  • the issue ID (TIKA-XXXX)
    • is referenced in the title of the pull request
    • and placed in front of your commit messages surrounded by square brackets ([TIKA-XXXX] Issue or pull request title)
  • commits are squashed into a single one (or few commits for larger changes)
  • Tika is successfully built and unit tests pass by running mvn clean test
  • there should be no conflicts when merging the pull request branch into the recent main branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled main branch
  • if you add new module that downstream users will depend upon add it to relevant group in tika-bom/pom.xml.

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!

@tballison
Copy link
Contributor

Should this be against the main branch?

@theit theit changed the base branch from TIKA-4137 to main September 22, 2023 13:10
@theit
Copy link
Contributor Author

theit commented Sep 22, 2023

Erm, yes, indeed. For sure :-)
(sorry, haven't seen that I mistakenly chose the wrong destination...)

@tballison tballison merged commit 72a81a1 into apache:main Sep 22, 2023
tballison pushed a commit that referenced this pull request May 15, 2024
* TIKA-4137 -- Building current Tika main branch fails under Java 20/21

Authored-by: thorsten <thorsten@mbpvonthorsten.fritz.box>
(cherry picked from commit 72a81a1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants