Additional fix for BZ 64848. Ensure Processor instances are cleaned up

apache · Nov 5, 2020 · fde779b · fde779b
1 parent dfda626
commit fde779b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/java/org/apache/coyote/AbstractProcessor.java b/java/org/apache/coyote/AbstractProcessor.java
@@ -86,6 +86,9 @@ public AbstractProcessor(AbstractEndpoint<S> endpoint) {
      * @param t The error which occurred
      */
     protected void setErrorState(ErrorState errorState, Throwable t) {
+        if (getLog().isDebugEnabled()) {
+            getLog().debug(sm.getString("abstractProcessor.setErrorState", errorState), t);
+        }
         // Use the return value to avoid processing more than one async error
         // in a single async cycle.
         boolean setError = response.setError();

diff --git a/java/org/apache/coyote/LocalStrings.properties b/java/org/apache/coyote/LocalStrings.properties
@@ -21,6 +21,7 @@ abstractConnectionHandler.socketexception.debug=SocketExceptions are normal, ign
 abstractProcessor.fallToDebug=\n\
 \ Note: further occurrences of request parsing errors will be logged at DEBUG level.
 abstractProcessor.hostInvalid=The host [{0}] is not valid
+abstractProcessor.setErrorState=Error state [{0}] reported while processing request
 
 abstractProtocolHandler.destroy=Destroying ProtocolHandler [{0}]
 abstractProtocolHandler.destroyError=Failed to destroy end point associated with ProtocolHandler [{0}]

diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
@@ -101,6 +101,10 @@
         <bug>55160</bug>: Re-fix this bug after the original fix was reverted by
         a separate fix to timeouts in 7.0.81. (markt)
       </fix>
+      <add>
+        Add additional debug logging for I/O issues when communicating with the
+        user agent. (markt)
+      </add>
     </changelog>
   </subsection>
   <subsection name="Web applications">
@@ -141,8 +145,7 @@
       <fix>
         Complete the fix for <bug>63815</bug>. Users wishing to use system
         properties that require quoting with <code>catalina.sh</code> and the
-        <code>debug</code> option must use a JRE that includes the fix for <a
-        href="https://bugs.openjdk.java.net/browse/JDK-8234808">JDK-8234808</a>.
+        <code>debug</code> option must use a JRE that includes the fix for <a href="https://bugs.openjdk.java.net/browse/JDK-8234808">JDK-8234808</a>.
         (markt)
       </fix>
       <add>