Remove unnecessary JOIN #5184
Merged
Remove unnecessary JOIN #5184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
added
bug
|
2 birds w/ one stone. i like it! |
|
seems like more than a |
|
idk, things seem to have been working fine without this fix for the past year and a half, so I think it's minor. But I don't care what you do to the labels, make it whatever you want |
well ds thresholds have been broken, right? seems more than minor for anyone wanting to use ds thresholds :) |
mitchell852
added
medium impact
zrhoffman
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
- Confirmed that the correct values for
TotalTpsThresholdandTotalKbpsThresholdshow up in- TM's
/api/monitor-config - API versions 1.1, 2.0, and 3.0 of
/cdns/{name}/configs/monitoring
- TM's
We don't lose any specificity by removing the JOIN, since a Delivery Service (optionally unless using MSO) has only 1 profile.
ocket8888
added a commit
that referenced
this pull request
Oct 22, 2020
* Remove unnecessary JOIN * Fix tests, also some context leaks * Add to CHANGELOG (cherry picked from commit 330ac87)
rawlinp
pushed a commit
to rawlinp/trafficcontrol
that referenced
this pull request
Oct 27, 2020
* Remove unnecessary JOIN * Fix tests, also some context leaks * Add to CHANGELOG (cherry picked from commit 330ac87)
rawlinp
added a commit
that referenced
this pull request
Oct 27, 2020
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make a GET request to
/cdn/{{Some CDN}}/configs/monitoringwhereSome CDNis the name of some CDN containing at least one Delivery Service. Notice the array of Delivery Services is not empty.If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR