Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

servers/details endpoint #5611

Merged
merged 7 commits into from
Mar 17, 2021
Merged

servers/details endpoint #5611

merged 7 commits into from
Mar 17, 2021

Conversation

tyagian
Copy link
Contributor

@tyagian tyagian commented Mar 6, 2021

What does this PR (Pull Request) do?

  • This PR is not related to any issue

This will add servers/details endpoint to Python client.

Which Traffic Control components are affected by this PR?

  • Traffic Control Client (Python)

What is the best way to verify this PR?

  • call the added method, ensure it works

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888
Copy link
Contributor

What does this pull request do?

@tyagian
Copy link
Contributor Author

tyagian commented Mar 8, 2021

This will add servers/details endpoint to Python client.
https://traffic-control-cdn.readthedocs.io/en/latest/api/v4/servers_details.html#to-api-servers-details

@ocket8888 ocket8888 self-assigned this Mar 8, 2021
@ocket8888 ocket8888 added new feature A new feature, capability or behavior TC Client (python) related to the Python implementation of a TC client labels Mar 8, 2021
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but note that it only works if you pass the name parameter; it can't call servers/details, it can only do it by passing the hostName query parameter. So getting details for all servers is an N+1 problem for this method.

Which is still better than nothing at all

@ocket8888 ocket8888 merged commit 0170bba into apache:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature A new feature, capability or behavior TC Client (python) related to the Python implementation of a TC client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants