Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set defaults for simplicity environment variables #6420

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Set defaults for simplicity environment variables #6420

merged 1 commit into from
Dec 15, 2021

Conversation

zrhoffman
Copy link
Member

@zrhoffman zrhoffman commented Dec 10, 2021 •
edited
Loading

This PR fixes #6419 by setting default values for the simplicity build options added in #6274.

Which Traffic Control components are affected by this PR?

  • Build system

What is the best way to verify this PR?

  1. Install dependencies needed to build the RPMs "natively"
  2. Go to the CDN in a Box directory
  3. Verify that make native passes

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@zrhoffman zrhoffman added bug something isn't working as intended build related to the build process labels Dec 10, 2021
@zrhoffman zrhoffman requested a review from ocket8888 December 10, 2021 22:43
shamrickus
shamrickus approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@shamrickus shamrickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Able to recreate issue on master, no longer occuring

@shamrickus shamrickus merged commit 3fbcc2f into apache:master Dec 15, 2021
@zrhoffman zrhoffman deleted the simpl-defaults branch December 15, 2021 20:32
@asheikm asheikm mentioned this pull request Dec 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamrickus shamrickus shamrickus approved these changes

@ocket8888 ocket8888 Awaiting requested review from ocket8888

Assignees
No one assigned
Labels
bug something isn't working as intended build related to the build process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CDN in a Box make native fails: NO_LOG_FILES: unbound variable
2 participants
@zrhoffman @shamrickus