Display secure parameters when role has proper perms #7688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholguin
added
bug
Codecov Report
@@ Coverage Diff @@
## master #7688 +/- ##
============================================
- Coverage 29.78% 29.78% -0.01%
Complexity 98 98
============================================
Files 802 802
Lines 85789 85797 +8
Branches 952 952
============================================
+ Hits 25550 25551 +1
- Misses 58099 58107 +8
+ Partials 2140 2139 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ocket8888
reviewed
Aug 2, 2023
…trol into secure-params-fix
cybertunnel
pushed a commit
to cybertunnel/trafficcontrol
that referenced
this pull request
Aug 16, 2023
* fix conditional for secure parameters * add change * handle v5 functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when role based permissions are enabled and a user has the
PARAMETERS-SECURE:READpermissions they are still unable to view a secure parameter's value.This PR fixes that and user's can view the secure value when they have permission.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run Traffic Ops with
role_based_permissionsenabledWill need to have a non admin role with
PARAMETERS-SECURE:READpermissions and a Parameter with secure set to trueShould be able to view the value with the non-admin role when using 4.0 and should see hidden value when using 3.0 and value should be hidden when the role does not have the
PARAMETERS-SECURE:READpermissionIf this is a bugfix, which Traffic Control versions contained the bug?
I'm not sure?
PR submission checklist