Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing changelog entries for v5 routes #7890

Merged

Conversation

rimashah25
Copy link
Contributor

Added missing changelog entries for APIv5 routes.


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Using TP, perform any operation (create a profile, update a parameter, delete a server etc) and changelog should record all these operations.

If this is a bugfix, which Traffic Control versions contained the bug?

8.0.0

PR submission checklist

@rimashah25 rimashah25 marked this pull request as ready for review December 20, 2023 20:01
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 86 lines in your changes are missing coverage. Please review.

Comparison is base (83556e8) 31.32% compared to head (fe77be1) 31.80%.

Files Patch % Lines
traffic_ops/traffic_ops_golang/cdn/cdns.go 0.00% 8 Missing ⚠️
...fic_ops/traffic_ops_golang/parameter/parameters.go 0.00% 8 Missing ⚠️
traffic_ops/traffic_ops_golang/asn/asns.go 0.00% 6 Missing ⚠️
...c_ops/traffic_ops_golang/cachegroup/cachegroups.go 0.00% 6 Missing ⚠️
...affic_ops/traffic_ops_golang/division/divisions.go 0.00% 6 Missing ⚠️
traffic_ops/traffic_ops_golang/origin/origins.go 0.00% 6 Missing ⚠️
.../traffic_ops_golang/physlocation/phys_locations.go 0.00% 6 Missing ⚠️
traffic_ops/traffic_ops_golang/profile/profiles.go 0.00% 6 Missing ⚠️
..._ops_golang/profileparameter/profile_parameters.go 0.00% 6 Missing ⚠️
traffic_ops/traffic_ops_golang/region/regions.go 0.00% 6 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #7890      +/-   ##
============================================
+ Coverage     31.32%   31.80%   +0.47%     
  Complexity       98       98              
============================================
  Files           660      719      +59     
  Lines         78935    82816    +3881     
  Branches        970      970              
============================================
+ Hits          24729    26340    +1611     
- Misses        52149    54318    +2169     
- Partials       2057     2158     +101     
Flag Coverage Δ
golib_unit 53.84% <ø> (-0.01%) ⬇️
grove_unit 12.02% <ø> (ø)
t3c_unit 5.88% <ø> (ø)
traffic_monitor_unit 25.47% <ø> (ø)
traffic_ops_integration 69.42% <ø> (-9.47%) ⬇️
traffic_ops_unit 21.63% <2.27%> (-0.04%) ⬇️
traffic_portal_v2 74.37% <ø> (+0.01%) ⬆️
traffic_stats_unit 10.78% <ø> (?)
unit_tests 29.12% <2.27%> (-0.34%) ⬇️
v3 57.79% <ø> (?)
v4 79.18% <ø> (ø)
v5 78.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will merge once tests finish running.

@zrhoffman zrhoffman added bug something isn't working as intended Traffic Ops related to Traffic Ops labels Dec 20, 2023
@zrhoffman zrhoffman merged commit 63c6471 into apache:master Dec 20, 2023
83 checks passed
@rimashah25 rimashah25 deleted the bugfix/add-missing-changelog-v5routes branch December 20, 2023 22:42
rimashah25 added a commit that referenced this pull request Jan 3, 2024
* Fixed ASN routes to produce changelog entries

* Adding missing changelog entries to v5 routes

* updated changelog

---------

Co-authored-by: Chatterjee, Srijeet <srijeet_chatterjee@comcast.com>
(cherry picked from commit 63c6471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants