Skip to content

Commit

Permalink
[microTVM] Fix timeout of -1 breaking Arduino transport (#12189)
Browse files Browse the repository at this point in the history
* Remove warning from Teensy boards

* Use a real timeout

* Skip assertion of whether a functional schedule exists

* Don't specify least significant digits for Teensy boards
  • Loading branch information
guberti authored Jul 27, 2022
1 parent 584b0f3 commit 03aed78
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
5 changes: 2 additions & 3 deletions apps/microtvm/arduino/template_project/boards.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,15 @@
"package": "teensy",
"architecture": "avr",
"board": "teensy40",
"model": "imxrt1060",
"note": "The Teensy boards are listed here for completeness, but they won't work until https://github.com/arduino/arduino-cli/issues/700 is finished.",
"model": "imxrt10xx",
"vid_hex": "16c0",
"pid_hex": "0478"
},
"teensy41": {
"package": "teensy",
"architecture": "avr",
"board": "teensy41",
"model": "imxrt1060",
"model": "imxrt10xx",
"vid_hex": "16c0",
"pid_hex": "0478"
},
Expand Down
4 changes: 3 additions & 1 deletion python/tvm/micro/testing/evaluation.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ def tune_model(
],
si_prefix="M",
)
assert tuner.best_flops > 1
# Note that we might not find a working schedule at all, in which case
# tuner.best_flops would equal zero. This is not good, but checking for
# this case will happen elsewhere.

return results

Expand Down
2 changes: 1 addition & 1 deletion tests/micro/arduino/test_arduino_workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def uploaded_project(compiled_project):
def serial_output(uploaded_project):
transport = uploaded_project.transport()
transport.open()
out = transport.read(2048, -1)
out = transport.read(2048, 60)
out_str = out.decode("utf-8")
out_lines = out_str.split("\r\n")

Expand Down

0 comments on commit 03aed78

Please sign in to comment.