Verify that removed expression has no other side effects

apache · Aug 5, 2022 · 55737e0 · 55737e0
1 parent 6bc63cb
commit 55737e0
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/tir/transforms/remove_store_undef.cc b/src/tir/transforms/remove_store_undef.cc
@@ -49,6 +49,9 @@ class StoreUndefLocator : public StmtExprVisitor {
     StmtExprVisitor::VisitExpr(op->value);
     std::swap(has_undef_, stash_undef);
     if (stash_undef) {
+      ICHECK(SideEffect(op->value) <= CallEffectKind::kReadState)
+          << "Error: T.undef() used in BufferStore expressions "
+          << "must not have other side effects";
       undef_stores_.insert(op);
     }
   }
@@ -66,6 +69,9 @@ class StoreUndefLocator : public StmtExprVisitor {
     StmtExprVisitor::VisitExpr(op->value);
     std::swap(has_undef_, stash_undef);
     if (stash_undef) {
+      ICHECK(SideEffect(op->value) <= CallEffectKind::kReadState)
+          << "Error: T.undef() used in Let expressions "
+          << "must not have other side effects";
       var_bindings_with_undef_.insert(op->var.get());
     }