-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip ci][ci][docker] Prune all non-relevant images #11491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
force-pushed
the
dprune
branch
2 times, most recently
from
May 27, 2022 18:07
f15735b
to
5d8f2da
Compare
Before this would leave around any image that could be used in CI. This PR changes it so that the `docker rmi` knows exactly which image is being used in CI so all others (even those that are being used in the same build but not currently on that node) are deleted This also adds some more logging so we can see what's going on and should help keep disk usage down.
driazati
changed the title
[ci][docker] Prune all non-relevant images
[skip ci][ci][docker] Prune all non-relevant images
May 27, 2022
areusch
approved these changes
May 27, 2022
driazati
added a commit
to driazati/tvm
that referenced
this pull request
May 27, 2022
…apache#11491)" This reverts commit c253053.
areusch
pushed a commit
that referenced
this pull request
May 27, 2022
shouldn't have skipped CI on this one, the Jenkinsfile needed to read a variable during groovy execution that wasn't set correctly |
driazati
added a commit
to driazati/tvm
that referenced
this pull request
May 27, 2022
(this is a re-do of apache#11491) Before this would leave around any image that could be used in CI. This PR changes it so that the `docker rmi` knows exactly which image is being used in CI so all others (even those that are being used in the same build but not currently on that node) are deleted This also adds some more logging so we can see what's going on and should help keep disk usage down. Skipped CI since this runs during lint.
driazati
added a commit
to driazati/tvm
that referenced
this pull request
May 27, 2022
Before this would leave around any image that could be used in CI. This PR changes it so that the `docker rmi` knows exactly which image is being used in CI so all others (even those that are being used in the same build but not currently on that node) are deleted This also adds some more logging so we can see what's going on and should help keep disk usage down. Co-authored-by: driazati <driazati@users.noreply.github.com>
driazati
added a commit
to driazati/tvm
that referenced
this pull request
May 27, 2022
driazati
added a commit
to driazati/tvm
that referenced
this pull request
May 27, 2022
(this is a re-do of apache#11491) Before this would leave around any image that could be used in CI. This PR changes it so that the `docker rmi` knows exactly which image is being used in CI so all others (even those that are being used in the same build but not currently on that node) are deleted This also adds some more logging so we can see what's going on and should help keep disk usage down. Skipped CI since this runs during lint.
driazati
added a commit
to driazati/tvm
that referenced
this pull request
May 27, 2022
Before this would leave around any image that could be used in CI. This PR changes it so that the `docker rmi` knows exactly which image is being used in CI so all others (even those that are being used in the same build but not currently on that node) are deleted This also adds some more logging so we can see what's going on and should help keep disk usage down. Co-authored-by: driazati <driazati@users.noreply.github.com>
driazati
added a commit
to driazati/tvm
that referenced
this pull request
May 27, 2022
driazati
added a commit
to driazati/tvm
that referenced
this pull request
May 27, 2022
(this is a re-do of apache#11491) Before this would leave around any image that could be used in CI. This PR changes it so that the `docker rmi` knows exactly which image is being used in CI so all others (even those that are being used in the same build but not currently on that node) are deleted This also adds some more logging so we can see what's going on and should help keep disk usage down. Skipped CI since this runs during lint.
areusch
pushed a commit
that referenced
this pull request
May 31, 2022
* [skip ci][ci][docker] Prune all non-relevant images (#11491) Before this would leave around any image that could be used in CI. This PR changes it so that the `docker rmi` knows exactly which image is being used in CI so all others (even those that are being used in the same build but not currently on that node) are deleted This also adds some more logging so we can see what's going on and should help keep disk usage down. Co-authored-by: driazati <driazati@users.noreply.github.com> * [skip ci] Revert "[skip ci][ci][docker] Prune all non-relevant images (#11491)" (#11496) * [ci][docker] Prune all non-relevant images (this is a re-do of #11491) Before this would leave around any image that could be used in CI. This PR changes it so that the `docker rmi` knows exactly which image is being used in CI so all others (even those that are being used in the same build but not currently on that node) are deleted This also adds some more logging so we can see what's going on and should help keep disk usage down. Skipped CI since this runs during lint. Co-authored-by: driazati <driazati@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this would leave around any image that could be used in CI. This PR changes it so that the
docker rmi
knows exactly which image is being used in CI so all others (even those that are being used in the same build but not currently on that node) are deletedThis also adds some more logging so we can see what's going on and should help keep disk usage down. Skipped CI since this runs during lint.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.
cc @Mousius @areusch