[BYOC] InlineCompilerFunctions helper pass #11923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TensorRT BYOC integration needs to 'undo' partitionings in some situations. Add an InlineCompilerFunctions pass to make that robust. In particular, it must undo both the 'partitioning' (ie separating out the "Compiler" function) and any 'compositing' (ie separating out small sub-graphs as "Composite" functions). Fix misspelled nn.bias_add while there. Note that the current implementation is broken but untested in CI. I have all the tests fixed in a follow-up PR.
masahi
approved these changes
Jun 27, 2022
comaniac
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
The changes look clean. Thanks!
One miner point is the name InlineCompilerFunctions seems a bit confusing although the implementation itself is general to inline functions with their global vars specified. Would that be better to just call something like InlineFunctions?
|
Thanks @comaniac, agree -- the iface changed but I forgot to update the pass name. |
junrushao
approved these changes
Jun 27, 2022
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
* [BYOC] InlineCompilerFunctions helper pass The TensorRT BYOC integration needs to 'undo' partitionings in some situations. Add an InlineCompilerFunctions pass to make that robust. In particular, it must undo both the 'partitioning' (ie separating out the "Compiler" function) and any 'compositing' (ie separating out small sub-graphs as "Composite" functions). Fix misspelled nn.bias_add while there. Note that the current implementation is broken but untested in CI. I have all the tests fixed in a follow-up PR. * - Lints * - Only AOT compilation paths ensure "executor" is provided as a Target attribute.
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
* [BYOC] InlineCompilerFunctions helper pass The TensorRT BYOC integration needs to 'undo' partitionings in some situations. Add an InlineCompilerFunctions pass to make that robust. In particular, it must undo both the 'partitioning' (ie separating out the "Compiler" function) and any 'compositing' (ie separating out small sub-graphs as "Composite" functions). Fix misspelled nn.bias_add while there. Note that the current implementation is broken but untested in CI. I have all the tests fixed in a follow-up PR. * - Lints * - Only AOT compilation paths ensure "executor" is provided as a Target attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TensorRT BYOC integration needs to 'undo' partitionings in some situations. Add an
InlineCompilerFunctions pass to make that robust. In particular, it must undo both the
'partitioning' (ie separating out the "Compiler" function) and any 'compositing' (ie separating
out small sub-graphs as "Composite" functions).
Fix misspelled nn.bias_add while there.
Note that the current implementation has been broken since #11203 (mea culpa) but was untested by CI. I have all the tests fixed in a follow-up PR and a few other bug fixes.