[TIR][Schedule] Refactor Tensorize #12070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately structural error reporting in pattern matching is NOT included in this PR, because it's currently blocked in TVMScript printer work by @yelite et al |
vinx13
approved these changes
Jul 12, 2022
Hzfengsy
reviewed
Jul 13, 2022
Hzfengsy
reviewed
Jul 13, 2022
Hzfengsy
reviewed
Jul 13, 2022
Hzfengsy
approved these changes
Jul 13, 2022
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jul 15, 2022
* Refactor blockize * Refactor tensorize * Address review comments * typo * rename variables according to review
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* Refactor blockize * Refactor tensorize * Address review comments * typo * rename variables according to review
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
* Refactor blockize * Refactor tensorize * Address review comments * typo * rename variables according to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the key schedule primitive
tensorize, cleaning up the logic and brings the following benefits:tensorizeis now failure-safe: previously if a failure happens betweenblockizeand structural pattern matching, the sref tree is left unmaintainedtensorizeis now correct if a TIR is tensorized multiple times with the same tensor intrin: previously the intrin is not deep copied, so the pointer equality used in ScheduleState will fail if the TIR is tensorized multiple timesPer discussion with @vinx13 @yzh119 @spectrometerHBH