[Relay] Allow Primitive functions to carry virtual device annotations in PlanDevices #12095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in PlanDevices Previously Primitive=1 functions not analyzed and calls to such were completely unconstrained. With this change at least any virtual device annotation on the function are respected and accounted for in calls, even though the body is not analyzed. This may help with piggy-backing on PlanDevices for doing memory scope analysis, since it is now possible to express cross-scope functions on Primitive functions. However I believe there are other issues to deal with in addition to this one.
When including virtual device annotations in test relay programs the annotation will typically use a target which was used as an input to the make_compilation_config helper, but due to various canonicalization make not be pointer equal to the final structurally equal target which ends up inside the constructed CompilationConfig. However VirtualDevices use pointer equality when comparing their target field. So make sure the notion of CanonicalVirtualDevice also accounts for canonical targets.
mbs-octoml
changed the title
jwfromm
approved these changes
Jul 14, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
… in PlanDevices (apache#12095) * [Relay] Allow Primitive function to carry virtual device annotations in PlanDevices Previously Primitive=1 functions not analyzed and calls to such were completely unconstrained. With this change at least any virtual device annotation on the function are respected and accounted for in calls, even though the body is not analyzed. This may help with piggy-backing on PlanDevices for doing memory scope analysis, since it is now possible to express cross-scope functions on Primitive functions. However I believe there are other issues to deal with in addition to this one. * - comments * - also canonicalize targets When including virtual device annotations in test relay programs the annotation will typically use a target which was used as an input to the make_compilation_config helper, but due to various canonicalization make not be pointer equal to the final structurally equal target which ends up inside the constructed CompilationConfig. However VirtualDevices use pointer equality when comparing their target field. So make sure the notion of CanonicalVirtualDevice also accounts for canonical targets. * - update unit test to reflect the Ardreno example * - trivial cleanup
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
… in PlanDevices (apache#12095) * [Relay] Allow Primitive function to carry virtual device annotations in PlanDevices Previously Primitive=1 functions not analyzed and calls to such were completely unconstrained. With this change at least any virtual device annotation on the function are respected and accounted for in calls, even though the body is not analyzed. This may help with piggy-backing on PlanDevices for doing memory scope analysis, since it is now possible to express cross-scope functions on Primitive functions. However I believe there are other issues to deal with in addition to this one. * - comments * - also canonicalize targets When including virtual device annotations in test relay programs the annotation will typically use a target which was used as an input to the make_compilation_config helper, but due to various canonicalization make not be pointer equal to the final structurally equal target which ends up inside the constructed CompilationConfig. However VirtualDevices use pointer equality when comparing their target field. So make sure the notion of CanonicalVirtualDevice also accounts for canonical targets. * - update unit test to reflect the Ardreno example * - trivial cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Primitive=1 functions were not analyzed and calls to such were completely
unconstrained. With this change at least any virtual device annotation on the function
are respected and accounted for in calls, even though the body is not analyzed.
While working on the unit test noticed it is possible to end up with two structurally equal
virtual devices which are not pointer equal even after canonicalization. Fix that by
introducing target canonicalization on the CompilationConfig.
This may help with piggy-backing on PlanDevices for doing memory scope analysis, since
it is now possible to express cross-scope functions on Primitive functions. However
I believe there are other issues to deal with in addition to this one.