[TVMScript] Printer Registry #12237
Merged
[TVMScript] Printer Registry #12237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
yelite
force-pushed
the
tunip-registry
branch
3 times, most recently
from
4c010ca
to
a472810
Compare
Co-authored-by: Junru Shao <jshao@octoml.ai> Co-authored-by: Greg Bonik <gbonik@octoml.ai>
junrushao
reviewed
Aug 8, 2022
junrushao
reviewed
Aug 8, 2022
junrushao
reviewed
Aug 8, 2022
junrushao
reviewed
Aug 8, 2022
| const String& token, uint32_t type_index); | ||
| void SetDispatchFunction(DispatchTable* dispatch_table, const String& token, uint32_t type_index, | ||
| runtime::PackedFunc f); | ||
| } // namespace dispatch_table |
There was a problem hiding this comment.
Curious why we are having an extra namespace? If it's not for name conflict, let's manage to reduce the namespace nesting here
There was a problem hiding this comment.
If they are used only in TracedObjectFunctor, do you think we could move them to its static members?
There was a problem hiding this comment.
I removed the nested namespace. We can't move them to static members of TracedObjectFunction, because it's a templated class. This will defeat the original purpose of separating those functions (reduce binary bloat and hide implementation detail from header)
gbonik
reviewed
Aug 8, 2022
gbonik
reviewed
Aug 8, 2022
gbonik
approved these changes
Aug 8, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This PR: - Adds the registry of printing function (traced_object_layered_functor.cc) Compared to the prototype version, this: - Consolidates the implementation into a single class, since this class is only for the TVMScript printer. - Deduces the TObjectRef when calling set_dispatch. Tracking issue: apache#11912 Co-authored-by: Greg Bonik <gbonik@octoml.ai>
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
This PR: - Adds the registry of printing function (traced_object_layered_functor.cc) Compared to the prototype version, this: - Consolidates the implementation into a single class, since this class is only for the TVMScript printer. - Deduces the TObjectRef when calling set_dispatch. Tracking issue: apache#11912 Co-authored-by: Greg Bonik <gbonik@octoml.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Compared to the prototype version, this:
Tracking issue: #11912
cc @junrushao1994 @gbonik