-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UnitTest][TIR] Testing utility for before/after transform tests #12264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2022
junrushao
approved these changes
Aug 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very cool improvement over the existing test infra! Thanks for making this happen!
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Sep 27, 2022
A follow-up commit from apache#12264. This allows the before/expected fixtures generated by `tvm.testing.CompareBeforeAfter` to be `IRModule` instances as well as `PrimFunc`. This is intended to allow testing that requires comparing more than one function (e.g. hoisting/fusing a PrimFunc).
csullivan
pushed a commit
that referenced
this pull request
Oct 7, 2022
…12920) A follow-up commit from #12264. This allows the before/expected fixtures generated by `tvm.testing.CompareBeforeAfter` to be `IRModule` instances as well as `PrimFunc`. This is intended to allow testing that requires comparing more than one function (e.g. hoisting/fusing a PrimFunc). * Prevent circular fixture references
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…che#12264) This PR adds `tvm.testing.CompareBeforeAfter`, a generalization of the `BaseBeforeAfter` utility previously used in `test_tir_transform_simplify.py`, which performs unit tests that perform a transformation on a TIR function and compare the results to an expected TIR output. This arose when minimizing the boilerplate required for unit tests in the implementation of apache#12261.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…pache#12920) A follow-up commit from apache#12264. This allows the before/expected fixtures generated by `tvm.testing.CompareBeforeAfter` to be `IRModule` instances as well as `PrimFunc`. This is intended to allow testing that requires comparing more than one function (e.g. hoisting/fusing a PrimFunc). * Prevent circular fixture references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
tvm.testing.CompareBeforeAfter
, a generalization of theBaseBeforeAfter
utility previously used intest_tir_transform_simplify.py
, which performs unit tests that perform a transformation on a TIR function and compare the results to an expected TIR output. This arose when minimizing the boilerplate required for unit tests in the implementation of #12261.