Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HotFix] Op is not bound to any variables #12401

Merged
merged 3 commits into from
Aug 16, 2022

Conversation

echuraev
Copy link
Contributor

@echuraev echuraev commented Aug 12, 2022

After PR #12349 inference of some Adreno networks was broken. In the
output it was the following error:

TVMError: Not all Vars are passed in api_args: 'compute' is not bound
to any variables

cc: @tkonolige, @Lunderberg

cc @driazati

After PR apache#12349 inference of some Adreno networks was broken. In the
output it was the following error:
```
TVMError: Not all Vars are passed in api_args: 'compute' is not bound
to any variables
```
Copy link
Contributor

@Lunderberg Lunderberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the catch, and I agree, this would be an issue as the previous version didn't visit the body of the letstmt. One recommended change to handle edge cases.

Also, is there an example before/after that demostrates this issue that could also added as a unit test?

src/tir/transforms/storage_rewrite.cc Outdated Show resolved Hide resolved
@echuraev echuraev marked this pull request as ready for review August 12, 2022 16:41
@github-actions github-actions bot requested a review from driazati August 15, 2022 07:09
Copy link
Contributor

@Lunderberg Lunderberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csullivan csullivan merged commit 1ba17fe into apache:main Aug 16, 2022
@csullivan
Copy link
Contributor

Thanks @echuraev @Lunderberg for the great follow up. This is merged.

xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
* [HotFix] Op is not bound to any variables

After PR apache#12349 inference of some Adreno networks was broken. In the
output it was the following error:
```
TVMError: Not all Vars are passed in api_args: 'compute' is not bound
to any variables
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants