-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use std::optional instead of dmlc::optional, NFC #12443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. BTW, do you prefer using tvm::runtime::Optinonal
instead for TVM objects?
Otherwise std::optional<T>::value() is "unavailable"...
I think that Edit: I prefer to use existing library classes and functions in general. |
Yeah my question is definitely a bit off the topic, so we don't have to deal with this in this PR - feel free to consider this as a discussion instead. My point here is that |
How about we also clean up this? tvm/src/tir/ir/buffer_common.h Lines 42 to 45 in c8a892b
|
Yes, I'll have another PR. |
* Use std::optional instead of dmlc::optional, NFC * Fix linter * Set deployment target to macOS 10.13 Otherwise std::optional<T>::value() is "unavailable"... * Fix linter again * Update Hexagon apps to use C++17 as the C++ standard
No description provided.