[ETHOSN] Support conversion of add to depthwise #12531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In similar fashion to the conversion of mul to depthwise, this commit converts add when one input is a constant of shape [1, ..., n] to a depthwise convolution. If neither input is a constant, the add is offloaded naturally like before. The addition testing has been improved to use pytest features. Change-Id: I93e7b7619736767992e70aaa6e60e0d7a2875f76
NicolaLancellotti
approved these changes
Aug 25, 2022
leandron
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
LGTM. Thanks @lhutton1 and @NicolaLancellotti for the review.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
In similar fashion to the conversion of mul to depthwise, this commit converts add when one input is a constant of shape [1, ..., n] to a depthwise convolution. If neither input is a constant, the add is offloaded naturally like before. The addition testing has been improved to use pytest features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In similar fashion to the conversion of mul to depthwise, this commit converts add when one input is a constant of shape [1, ..., n] to a depthwise convolution. If neither input is a constant, the add is offloaded naturally like before.
The addition testing has been improved to use pytest features.
Note that this PR also contains the contents of #12403 until it is merged.cc @NicolaLancellotti @leandron @ashutosh-arm