Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIR, Schedule] Check consumer in-bound and covered in reverse_compute_inline #12717

Merged
merged 3 commits into from
Sep 9, 2022
Merged

[TIR, Schedule] Check consumer in-bound and covered in reverse_compute_inline #12717

merged 3 commits into from
Sep 9, 2022

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented Sep 6, 2022 •
edited
Loading

  • When the producer region is larger than the consumer region, reverse_compute_inline should generate predicates to prevent out-of-bound access to the consumer region.
  • Check the consumer block iter domains are covered by the producer after inlining.
    cc @spectrometerHBH @Hzfengsy @jwfromm

@vinx13 vinx13 force-pushed the feat/reverse-compute-inline-predicate branch from cb719ab to 58ff35d Compare September 6, 2022 19:37
@vinx13 vinx13 force-pushed the feat/reverse-compute-inline-predicate branch 2 times, most recently from d3428c6 to 7699100 Compare September 8, 2022 19:07
@vinx13 vinx13 force-pushed the feat/reverse-compute-inline-predicate branch from 7699100 to ac4a9ec Compare September 8, 2022 19:08
@vinx13 vinx13 changed the title [TIR, Schedule] Generate consumer-in-bound predicate after reverse_compute_inline [TIR, Schedule] Check consumer in-bound and covered in reverse_compute_inline Sep 8, 2022
@github-actions github-actions bot requested a review from jwfromm September 8, 2022 19:10
jwfromm
jwfromm approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@jwfromm jwfromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent. Thank you Wuwei!

@jwfromm jwfromm merged commit 89ce171 into apache:main Sep 9, 2022
@jwfromm
Copy link
Contributor

jwfromm commented Sep 9, 2022

Thank you @vinx13, this now merged!

@AndrewZhaoLuo AndrewZhaoLuo mentioned this pull request Oct 4, 2022
Closed
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@vinx13 @xinetzone
[TIR, Schedule] Check consumer in-bound and covered in reverse_comput…
b2db293 
…e_inline (apache#12717)

* [TIR, Schedule] Generate consumer-in-bound predicate after reverse_compute_inline

* Check consumer block iters are covered

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwfromm jwfromm jwfromm approved these changes

@Hzfengsy Hzfengsy Awaiting requested review from Hzfengsy

@spectrometerHBH spectrometerHBH Awaiting requested review from spectrometerHBH

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinx13 @jwfromm