[ETHOSN] Consolidate target string usage #13159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Removes support for a deprecated target string. The deprecation warning has been around for a couple of releases now so it should be safe to remove. The target to use moving forward is: `ethos-n -variant=n78 ...` Refactored direct use of a driver stack target string in the testing infrastructure to use the same string we expect users to provide. This simplified some of the code in codegen and hopefully avoids confusion in the future. Change-Id: Ic50842e15725d6440efc1ab525ac7dd9a4068ac4
lhutton1
force-pushed
the
remove-deprecated-target
branch
from
5cf2df4 to
6242010
Compare
|
This is ready for review :) |
leandron
approved these changes
Nov 8, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 10, 2022
* [ETHOSN] Consolidate target string usage Removes support for a deprecated target string. The deprecation warning has been around for a couple of releases now so it should be safe to remove. The target to use moving forward is: `ethos-n -variant=n78 ...` Refactored direct use of a driver stack target string in the testing infrastructure to use the same string we expect users to provide. This simplified some of the code in codegen and hopefully avoids confusion in the future.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* [ETHOSN] Consolidate target string usage Removes support for a deprecated target string. The deprecation warning has been around for a couple of releases now so it should be safe to remove. The target to use moving forward is: `ethos-n -variant=n78 ...` Refactored direct use of a driver stack target string in the testing infrastructure to use the same string we expect users to provide. This simplified some of the code in codegen and hopefully avoids confusion in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes support for a deprecated target string. The deprecation warning has been around for a couple of releases now so it should be safe to remove. The target to use moving forward is:
ethos-n -variant=n78 ...Refactored direct use of a driver stack target string in the testing infrastructure to use the same string we expect users to provide. This simplified some of the code in codegen and hopefully avoids confusion in the future.
cc @Leo-arm @ashutosh-arm @leandron @Mousius