Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AOT] Add CreateExecutorMetadata analysis pass #13250

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

mbaret
Copy link
Contributor

@mbaret mbaret commented Nov 1, 2022

Tracking issue: #12548

AOT requires the ExecutorCodegenMetadata object to be populated containing various pieces of information about the compiled module. This commit adds a separate analysis pass to create the metadata + some tests for the new pass.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Nov 1, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@mbaret
Copy link
Contributor Author

mbaret commented Nov 1, 2022

cc also @ekalda

Copy link
Contributor

@ekalda ekalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Didn't even find any typos...

AOT requires the ExecutorCodegenMetadata object to be
populated containing various pieces of information about
the compiled module. This commit adds a separate analysis
pass to create the metadata + some tests for the new pass.

In order to collect the device information correctly,
AOTLowerMain is extended to attach the device info as a
function attribute.
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbaret, LGTM!

Just a nit: a test for multiple input and outputs might be helpful? But happy for it to come in a followup

Copy link
Contributor

@ekalda ekalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbaret, looks good from my side! CI seems a bit stuck though...

@ekalda
Copy link
Contributor

ekalda commented Nov 8, 2022

@tvm-bot rerun

@lhutton1 lhutton1 merged commit 0e395c3 into apache:main Nov 9, 2022
@lhutton1
Copy link
Contributor

lhutton1 commented Nov 9, 2022

Thanks @mbaret @ekalda!

xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 10, 2022
AOT requires the ExecutorCodegenMetadata object to be
populated containing various pieces of information about
the compiled module. This commit adds a separate analysis
pass to create the metadata + some tests for the new pass.

In order to collect the device information correctly,
AOTLowerMain is extended to attach the device info as a
function attribute.
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
AOT requires the ExecutorCodegenMetadata object to be
populated containing various pieces of information about
the compiled module. This commit adds a separate analysis
pass to create the metadata + some tests for the new pass.

In order to collect the device information correctly,
AOTLowerMain is extended to attach the device info as a
function attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants