[ci] Split out C++ unittests #13335
Merged
[ci] Split out C++ unittests #13335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
driazati
force-pushed
the
split_cpp
branch
15 times, most recently
from
a48525e to
4a50f63
Compare
alanmacd
reviewed
Nov 10, 2022
ci/jenkins/Build.groovy.j2
Outdated
| @@ -208,7 +231,9 @@ stage('Build') { | |||
| script: "${docker_run} ${ci_hexagon} ./tests/scripts/task_config_build_hexagon.sh build", | |||
| label: 'Create Hexagon cmake config', | |||
| ) | |||
| make(ci_hexagon, 'build', '-j2') | |||
| cmake_build(ci_hexagon, 'build', '-j2') | |||
| make_standalone_crt(ci_hexagon, 'build') | |||
There was a problem hiding this comment.
We would want to remove make_standalone_crt() here for the hexagon build.
cc: @mehrdadh
driazati
force-pushed
the
split_cpp
branch
10 times, most recently
from
59fab28 to
93e6112
Compare
driazati
force-pushed
the
split_cpp
branch
2 times, most recently
from
607d10d to
38b484f
Compare
|
@driazati can you push your branch to a TVM branch to test the jenkins changes? |
|
Certain GitHub forks are configured in Jenkins to be trusted (e.g. those for people on the oss team), so the extra step to push to apache/tvm isn't necessary. You can see the info here: https://ci.tlcpack.ai/job/tvm/indexing/events, when a job comes from an untrusted source it'll say something like |
driazati
force-pushed
the
split_cpp
branch
9 times, most recently
from
03d9e44 to
96d73dc
Compare
This makes C++ unittests follow the normal flow of build -> upload artifacts -> download and run tests. To simplify the changes there is a new utility for interacting with S3.
driazati
force-pushed
the
split_cpp
branch
5 times, most recently
from
ac38e84 to
a20c8a0
Compare
mehrdadh
approved these changes
Nov 18, 2022
driazati
added a commit
to driazati/tvm
that referenced
this pull request
Nov 19, 2022
The docs deploy is broken following apache#13335: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/4754/pipeline This avoids downloading the whole docs directory (which is just used to host documentation previews for PRs) and just grabs the `docs.tgz` which is actually used to deploy the docs.
driazati
added a commit
to driazati/tvm
that referenced
this pull request
Nov 19, 2022
The docs deploy is broken following apache#13335: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/4754/pipeline This avoids downloading the whole docs directory (which is just used to host documentation previews for PRs) and just grabs the `docs.tgz` which is actually used to deploy the docs.
masahi
pushed a commit
that referenced
this pull request
Nov 21, 2022
The docs deploy is broken following #13335: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/4754/pipeline This avoids downloading the whole docs directory (which is just used to host documentation previews for PRs) and just grabs the `docs.tgz` which is actually used to deploy the docs. Co-authored-by: driazati <driazati@users.noreply.github.com>
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* [ci] Split out C++ unittests This makes C++ unittests follow the normal flow of build -> upload artifacts -> download and run tests. To simplify the changes there is a new utility for interacting with S3. * Comments Co-authored-by: driazati <driazati@users.noreply.github.com>
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
The docs deploy is broken following apache#13335: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/4754/pipeline This avoids downloading the whole docs directory (which is just used to host documentation previews for PRs) and just grabs the `docs.tgz` which is actually used to deploy the docs. Co-authored-by: driazati <driazati@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes C++ unittests follow the normal flow of build -> upload
artifacts -> download and run tests. To simplify the changes there is a
new utility for interacting with S3.