Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMSIS-NN] Global function that provides range based on dtype #13652

Merged
merged 2 commits into from
Dec 25, 2022

Conversation

ashutosh-arm
Copy link
Contributor

@ashutosh-arm ashutosh-arm commented Dec 21, 2022

Follow up from #13522 (comment).
Range for dtype was being sought differently from inside various CMSIS-NN tests. This commit provides
a common global function inside aot.py under tvm.testing that can provide (min, max) values based on the dtype.
In future, other AOT based targets can make use of this function to obtain the range.

cc @Mousius @lhutton1 @NicolaLancellotti

Range for dtype was being sought differently from
inside various CMSIS-NN tests. This commit has created
a common global function inside aot.py under
tvm.testing that can provide (min, max) values based
on the dtype. In future, other AOT based targets can
make use of this function to obtain the range.

Change-Id: Ifcea4b3ce3b8a1949080af662b1eb3af48fbdfc7
@tvm-bot
Copy link
Collaborator

tvm-bot commented Dec 21, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@github-actions github-actions bot requested review from Mousius and lhutton1 December 21, 2022 17:52
Change-Id: I9d7fa9030c301e273f903853979ec4f924564d34
Copy link
Contributor

@NicolaLancellotti NicolaLancellotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mousius Mousius merged commit e268014 into apache:main Dec 25, 2022
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
…#13652)

Range for dtype was being sought differently from
inside various CMSIS-NN tests. This commit has created
a common global function inside aot.py under
tvm.testing that can provide (min, max) values based
on the dtype. In future, other AOT based targets can
make use of this function to obtain the range.
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
…#13652)

Range for dtype was being sought differently from
inside various CMSIS-NN tests. This commit has created
a common global function inside aot.py under
tvm.testing that can provide (min, max) values based
on the dtype. In future, other AOT based targets can
make use of this function to obtain the range.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants