-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCM] Fixes compiling on ROCM 5 and accuracy on dense op #13847
Conversation
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
I checked this with Radeon VII, gfx906 and also works on this platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I test this with gfx908 but not works on the platform. See details as #13666 |
@ masahi @mvermeulen I use the commit masahi:rocm-t-fix to build and run code.But I get error as follow. onnx_rocm.py```from pyexpat import model dtype="float32" import logging import warnings def build(target:str,mod:tvm.IRModule, params:dict, input_name:str, input_data:np.ndarray, input:tuple, output: tuple) -> np.ndarray: def main(): main()
|
Fixes apache#13666 * Some bitcode files need to be updated * There is a strange, device-dependent accuracy issue when using the default topi `dense` op schedule on AMDGPU (see the issue above). I confirmed that other schedule works fine.
Fixes #13666
dense
op schedule on AMDGPU (see the issue above). I confirmed that other schedule works fine.