Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microNPU] Merge LUT activation with binary elementwise operation #13935

Conversation

Aleksei-grovety
Copy link
Contributor

Add binary elementwise operator to OptimizeLUTs pass to merge LUT activation with elementwise operation. This PR is preparation for implementation of SoftMax operation.

cc @leandron, @ekalda, @lhutton1

Add binary elementwise operator to OptimizeLUTs pass to merge LUT activation with elementwise operation.
@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 9, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@github-actions github-actions bot requested a review from leandron February 9, 2023 12:24
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexey-yazev, looks sensible to me, I just had a small nit from a previous issue with constant data types that should now be fixed

tests/python/contrib/test_ethosu/infra.py Show resolved Hide resolved
Copy link
Contributor

@ekalda ekalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexey-yazev, LGTM! When I initially implemented the LUT support, there was some binary elementwise issue I couldn't figure out, I suppose your previous fixes to binary elementwise have also removed that underlying issue... Great to see this fixed!

@lhutton1 lhutton1 merged commit cff4568 into apache:main Feb 9, 2023
@lhutton1
Copy link
Contributor

lhutton1 commented Feb 9, 2023

Thanks @alexey-yazev, @ekalda!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants