Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLML] Changes corresponding to OpenCL workspace refactorization #13972

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

srkreddy1238
Copy link
Contributor

OpenCL context accessing is changed while refactoring OpenCL backend.

OpenCL context accessing is changed while refactoring OpenCL backend.
@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 13, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: clml See #10317 for details

Generated by tvm-bot

Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot to update OpenCLML part in the PR with OpenCL workspace refactoring. Thank you for the PR.

src/runtime/contrib/clml/clml_runtime.cc Outdated Show resolved Hide resolved
src/runtime/contrib/clml/clml_runtime.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM. One question and after the answer or adding some changes (up to you, I'm ok with current version of code) it can be merged.

src/runtime/contrib/clml/clml_runtime.cc Outdated Show resolved Hide resolved
@echuraev echuraev merged commit e7ad4bc into apache:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants