Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRT] USE CMake for CRT standalone libraries #14025

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

mehrdadh
Copy link
Member

@mehrdadh mehrdadh commented Feb 17, 2023

This PR converts Makefile for standalone CRT libraries to a CMake file which is usable in template projects. After this PR we no longer need to have custom CMake scripts to build CRT standalone libraries but instead just include CMakeLists.txt file that is copied in the CRT lib and link the libraries.
Also changed apps/bundle_deploy/Makefile which was a result of this change.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 17, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: crt See #10317 for details

Generated by tvm-bot

@mehrdadh mehrdadh force-pushed the crt/add_cmake_for_libs branch from a41b10a to 3843568 Compare February 21, 2023 19:20
@mehrdadh mehrdadh changed the title [Draft][CRT] USE CMake for CRT standalone libraries [CRT] USE CMake for CRT standalone libraries Feb 21, 2023
@mehrdadh mehrdadh requested review from guberti and driazati February 21, 2023 19:21
@mehrdadh mehrdadh force-pushed the crt/add_cmake_for_libs branch from 5b36d4d to 6f47073 Compare February 22, 2023 00:58
@mehrdadh mehrdadh merged commit 330fe8d into apache:main Feb 22, 2023
@mehrdadh mehrdadh deleted the crt/add_cmake_for_libs branch February 22, 2023 17:57
yongwww pushed a commit to yongwww/tvm that referenced this pull request Feb 27, 2023
This PR converts Makefile for standalone CRT libraries to a CMake file which is usable in template projects. After this PR we no longer need to have custom CMake scripts to build CRT standalone libraries but instead just include CMakeLists.txt file that is copied in the CRT lib and link the libraries.
Also changed apps/bundle_deploy/Makefile which was a result of this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants