Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hexagon] Hexagon inference fix #14533

Merged
merged 2 commits into from
Apr 8, 2023
Merged

[hexagon] Hexagon inference fix #14533

merged 2 commits into from
Apr 8, 2023

Conversation

shtinsa
Copy link
Contributor

@shtinsa shtinsa commented Apr 7, 2023

  1. Resolves issue with kernels linking.
  2. Fixes warning generated by clang-15.

[hexagon] Hexagon infweerence fix
bf38797 
1. Resolves issue with kernels linking.
2. Fixes warning generated by clang-15.
@tvm-bot
Copy link
Collaborator

tvm-bot commented Apr 7, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@shtinsa
Copy link
Contributor Author

shtinsa commented Apr 7, 2023

@sunggg Could you please review the fix?

sunggg
sunggg approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@sunggg sunggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

csullivan
csullivan approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@csullivan csullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tqchen tqchen merged commit 8e92160 into apache:main Apr 8, 2023
@ysh329 ysh329 mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunggg sunggg sunggg approved these changes

@csullivan csullivan csullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shtinsa @tvm-bot @csullivan @sunggg @tqchen