[Tensorflow] Fix conv2d_transpose for NHWC layout

[jikechao]

If "data_format" == "NHWC", the kernel_layout for conv2d_transpose should be "HWOI" rather than "HWIO".

[tvm-bot]

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

• No users to tag found in teams: tensorflow _{See #10317 for details}

_{Generated by tvm-bot}

[jikechao]

As we can see in frontend about conv2d_transpose
, the kernel_layout for conv2d_transpose was set as "HWOI" when the data_layout='NHWC', while the Tensorflow frontend set the kernel_layout='HWIO' mistankenly. I submitted this PR to fix it.

@leandron @vvchernov Please help me review this PR. Thanks!

[yongwww]

@jikechao it would be good to add test cases for this fix

[vvchernov]

Hello @jikechao! Good fix. It looks like misprinting or thoughtless ctr+c, ctr+v from conv condition. I agree with @yongwww CI test is needed to check it

[jikechao]

@yongwww @vvchernov Thanks for your review.
I tried to construct a test case to trigger this bug but failed. By analyzing the source code, I found that the wrong logic statement is in a dead code. Specifically, when the op_name=='conv2d_transpose' and layout='NHWC', the layout was reset to 'NCHW' in this line: https://github.com/apache/tvm/blob/main/python/tvm/relay/frontend/tensorflow_ops.py#:~:text=if%20opname%20%3D%3D%20%22conv_transpose%22%20and,%22data_format%22%5D%20%3D%20%22NCHW%22

Thus, the condition if attr["data_format"] == "NHWC" always be False.
I deleted the wrong logic in the dead code. Please help me review it again. Thanks!

[echuraev]

@jikechao Thank you for your PR.

Specifically, when the op_name=='conv2d_transpose' and layout='NHWC', the layout was reset to 'NCHW' in this line: https://github.com/apache/tvm/blob/main/python/tvm/relay/frontend/tensorflow_ops.py#:~:text=if%20opname%20%3D%3D%20%22conv_transpose%22%20and,%22data_format%22%5D%20%3D%20%22NCHW%22

The link in your previous message is broken and doesn't highlight any line in the code. Also, could you please add a unit test for your changes?

[vvchernov]

Hello @jikechao! Thank you! You are right about condition fix, but it is still needed CI test to check that it works ok now and prevent further issue around it.

[jikechao]

@echuraev Indeed, this link can't redirect to the highlight place by clicking it directly. As a workaround, you can open this link by copying this link and past it into a new browser window.

I'll add a unit test sooner!

[vvchernov]

LGTM

[echuraev]

LGTM. Thanks. Please fix CI and then it can be merged.

[jikechao]

@echuraev CI fixed, could you help me merge this PR?

[echuraev]

@jikechao Thank you for your work :)