[Unity] Fix FuseOpsByPattern when a subgraph can be matched by multiple residual patterns #15308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this subgraph:
This subgraph matches to two different residual patterns
matmul -> add -> add
starting from each matmul and matching two out of threeadd
s. Currently we end up generating the following partition, since the secondadd
matches to both residual patterns and the two groups are merged incorrectly after the second matching.This bug has been fixed by checking, on successful pattern matching, whether there exists a matched expression that is part of a previously matched group.
@yelite @vinx13