Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Run tests/python/relay/aot tests in ci-cortexm #15519

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

ekalda
Copy link
Contributor

@ekalda ekalda commented Aug 10, 2023

The tests in tests/python/relay/aot were run as part of task_python_integration.sh which is run for ci-cpu and ci-arm, but some of tests in that folder require CMSIS-NN or FVP, so in practice they were not running anywhere in the upstream CI.

Since all the tests in that folder could run on ci-cortexm, change the scripts to run them there.

Also fix some tests that started failing as a result of #15103 (but didn't manifest in upstream CI) and test_device_api_hooks_unpacked_api that clearly hasn't been running in any CI for a while.

The tests in `tests/python/relay/aot` were run as part of
task_python_integration.sh which is run for `ci-cpu` and `ci-arm`, but
some of tests in that folder require CMSIS-NN or FVP, so in
practice they were not running anywhere in the upstream CI.

Since all the tests in that folder could run on `ci-cortexm`, change
the scripts run them there.

Also fix some tests that started failing as a result of apache#15103 (but
didn't manifest in upstream CI) and `test_device_api_hooks_unpacked_api`
that clearly hasn't been running in any CI for a while.
@tvm-bot
Copy link
Collaborator

tvm-bot commented Aug 10, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: test See #10317 for details

Generated by tvm-bot

@ekalda
Copy link
Contributor Author

ekalda commented Aug 10, 2023

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/scripts/task_python_integration.sh Show resolved Hide resolved
@lhutton1 lhutton1 merged commit 624f8a7 into apache:main Aug 11, 2023
@lhutton1
Copy link
Contributor

Thanks @ekalda!

@ekalda ekalda deleted the aot-test-cortexm branch August 11, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants