Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IRModule initialization with attrs #16202

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix IRModule initialization with attrs #16202

merged 1 commit into from
Dec 5, 2023

Conversation

jinhongyii
Copy link
Contributor

There's no test on IRModule initialization with attr, and there's an error with it. This PR fixes the behavior.

junrushao
junrushao approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that ast shouldn’t be part of IRModule

@tqchen tqchen merged commit 71081a8 into apache:main Dec 5, 2023
18 checks passed
@ysh329 ysh329 mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrushao junrushao junrushao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinhongyii @junrushao @tqchen