Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] add the default value for DFT in ONNX frontend #16659

Merged
merged 7 commits into from
Mar 4, 2024

Conversation

jikechao
Copy link
Contributor

@jikechao jikechao commented Feb 29, 2024

For the DFT operator (opset-17), The attribute of axis, inverse, and onesided is optional with a default value as shown in the ONNX documentation. This PR fixed such bugs and added corresponding tests.

Copy link
Member

@yongwww yongwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@tqchen tqchen merged commit 46aaf61 into apache:main Mar 4, 2024
14 checks passed
@tqchen
Copy link
Member

tqchen commented Mar 4, 2024

than you @jikechao for sending the fixes, as a community we are moving towards relax, and if you have some time, we love to also work together on improving relax frontends

@jikechao
Copy link
Contributor Author

jikechao commented Mar 5, 2024

than you @jikechao for sending the fixes, as a community we are moving towards relax, and if you have some time, we love to also work together on improving relax frontends

@tqchen Thanks. I'd be happy to improve the Relax!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants