[QoL][IR] Provide std::hash and std::equal_to for IR Variable types #16909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For most IR types, neither `std::hash` nor `std::equal_to` are provided, as it would be ambiguous whether comparisons should be performed with reference equality or structural equality. While this avoids ambiguity in the general case of nested structures, IR variables follow reference equality and are frequently used as lookup keys. This commit implements a specialization of `std::hash` and `std::equal_to` for `tvm::GlobalVar`, `tvm::tir::Var`, and `tvm::relax::Var`. This allows them to be used as lookup keys for `std::unordered_set` and `std::unordered_map` without explicitly specifying explicit `ObjectPtrHash` and `ObjectPtrEqual`.
masahi
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most IR types, neither
std::hashnorstd::equal_toare provided, as it would be ambiguous whether comparisons should be performed with reference equality or structural equality. While this avoids ambiguity in the general case of nested structures, IR variables follow reference equality and are frequently used as lookup keys.This commit implements a specialization of
std::hashandstd::equal_tofortvm::GlobalVar,tvm::tir::Var, andtvm::relax::Var. This allows them to be used as lookup keys forstd::unordered_setandstd::unordered_mapwithout explicitly specifying explicitObjectPtrHashandObjectPtrEqual.