[DLight] Check for target in function attributes #16958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `dlight` scheduling rules were applied solely based on the global `tvm.target.Target.current()`. However, a TIR PrimFunc may be annotated with the target, rather than using the global `Target.current()`. In this case, the `dlight` scheduling may produce a scheduled PrimFunc that is not compatible with its target. For example, using a thread binding to `"threadIdx.x"` on a CPU target. This commit updates `dlight` to check for a TIR PrimFunc's annotations when scheduling, matching the behavior of `tvm.build`.
masahi
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
dlightscheduling rules were applied solely based on the globaltvm.target.Target.current(). However, a TIR PrimFunc may be annotated with the target, rather than using the globalTarget.current(). In this case, thedlightscheduling may produce a scheduled PrimFunc that is not compatible with its target. For example, using a thread binding to"threadIdx.x"on a CPU target.This commit updates
dlightto check for a TIR PrimFunc's annotations when scheduling, matching the behavior oftvm.build.