Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVE] Add codegen support for vscale_range() function attribute #16962

Merged
merged 2 commits into from
May 8, 2024

Conversation

Anndrey24
Copy link
Contributor

This commit adds support for the vscale_range() LLVM function attribute to be generated for SVE and SME targets.

Some LLVM optimisation passes make use of the vscale_range() function attribute when scalable vectors are present (e.g. BasicAA llvm/llvm-project/pull/80445), so we include it alongside the "target_cpu" and "target-features" attributes.

cc @lhutton1

This commit adds support for the `vscale_range()` LLVM function attribute to be generated for SVE and SME targets.
Some LLVM optimisation passes make use of the `vscale_range()` function attribute when scalable vectors are present (e.g. BasicAA llvm/llvm-project/pull/80445), so we include it alongside the "target_cpu" and "target-features" attributes.
@github-actions github-actions bot requested a review from lhutton1 May 1, 2024 15:03
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Anndrey24, looks great!

src/target/llvm/codegen_llvm.cc Outdated Show resolved Hide resolved
@lhutton1
Copy link
Contributor

lhutton1 commented May 3, 2024

@tvm-bot rerun

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhutton1 lhutton1 merged commit 02c4c55 into apache:main May 8, 2024
20 checks passed
@lhutton1
Copy link
Contributor

lhutton1 commented May 8, 2024

Thanks @Anndrey24!

@Anndrey24 Anndrey24 deleted the vscale-range branch May 8, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants