[UIMA-6469] Cleaning up file handling code #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce various constants - Use try-with-resources to more effect
- Formatting
- Modernize and extend tests - More constants instead of magic strings - Centralize normalization of paths to unix paths - Improve JAR extraction handling - More try-with-resources
- Close file in test
bdeboe
added a commit
to bdeboe/uima-uimaj
that referenced
this pull request
Jan 23, 2023
This change introduces file-handling enhancements from apache#209 and apache#211 to the main-v2 branch, including the fix addressing CVE-2022-32287. This meant porting the entire org.apache.uima.util.impl.Constants class and also the unit test with associated org.junit.jupiter libraries. Given that these are only used in the test scope, it didn't feel too outrageous to use them just in this test and keep the others how they've always been in v2.
3 tasks
reckart
pushed a commit
that referenced
this pull request
Jan 24, 2023
This change introduces file-handling enhancements from #209 and #211 to the main-v2 branch, including the fix addressing CVE-2022-32287. This meant porting the entire org.apache.uima.util.impl.Constants class and also the unit test with associated org.junit.jupiter libraries. Given that these are only used in the test scope, it didn't feel too outrageous to use them just in this test and keep the others how they've always been in v2.
reckart
pushed a commit
that referenced
this pull request
Jan 24, 2023
This change introduces file-handling enhancements from #209 and #211 to the main-v2 branch, including the fix addressing CVE-2022-32287. This meant porting the entire org.apache.uima.util.impl.Constants class and also the unit test with associated org.junit.jupiter libraries. Given that these are only used in the test scope, it didn't feel too outrageous to use them just in this test and keep the others how they've always been in v2.
reckart
added a commit
that referenced
this pull request
Sep 23, 2024
- Allow settings a default validator for all tests and a specific validator per test
reckart
added a commit
that referenced
this pull request
Sep 23, 2024
…alidator-for-a-test Issue #209: Ability to override validator for a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: https://issues.apache.org/jira/browse/UIMA-6469
What's in the PR
How to test manually
Automatic testing
Documentation
Organizational
Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.