Fix tests on windows by Peter Hull #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asfgit
force-pushed
the
temp/ssteiner-windows
branch
2 times, most recently
from
3562354
to
964b035
Compare
Force test resource files to be binary On Windows, git would treat the unencoded files as text and apply CRLF line endings, so their base 64 encodings would not match the reference files. Work around timing issues on Windows On Windows the elapsed time was quite unreliable, causing intermittent fails in the performance tests, presumably made worse because PCs / the JRE are faster now then when this code was written. Also fixed up a few warnings/javadoc issues and replaced a home-grown bubble sort with Arrays.sort.
asfgit
force-pushed
the
temp/ssteiner-windows
branch
from
964b035
to
022bf92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force test resource files to be binary
On Windows, git would treat the unencoded files as text and apply CRLF line endings, so their base 64 encodings would not match the reference files.
Work around timing issues on Windows
On Windows the elapsed time was quite unreliable, causing intermittent fails in the performance tests, presumably made worse because PCs / the JRE are faster now then when this code was written.
Also fixed up a few warnings/javadoc issues and replaced a home-grown bubble sort with Arrays.sort.