[YUNIKORN-2991] The queue in Draining state does not accept new applications #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1002 +/- ##
==========================================
- Coverage 81.57% 81.55% -0.02%
==========================================
Files 97 97
Lines 15656 15659 +3
==========================================
Hits 12771 12771
- Misses 2601 2603 +2
- Partials 284 285 +1 ☔ View full report in Codecov by Sentry. |
|
See my comment in the jira, can we investigate doing the check in the AppPlacementManager? |
…ew applications" This reverts commit 8ab3e65.
rhh777
force-pushed
the
queue-draining
branch
from
7754387 to
f3d2d18
Compare
|
I have made the suggested modifications, and now the rejected information in the pod event information is not very clear. Should we display more rejection information? Before modification
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
When the queue is in the Drafting state, new applications are still allowed to be scheduled after submission.
I think we should refuse.
What type of PR is it?
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2991
How should this be tested?
Unit tests included